It seems as though the biggest problem is @topologic 's dependency on .NET. It's theoretically cross-platform, but in practice it's quite Windows-centric and a pain elsewhere.
@Moult said:
It seems as though the biggest problem is @topologic 's dependency on .NET. It's theoretically cross-platform, but in practice it's quite Windows-centric and a pain elsewhere.
The reason I approached this community was to see if there is anyone with the expertise and willingness to look at the C++ TopologicCore and port it to other platforms. Theoretically, Topologic has exactly the same dependency on OCCT (and no other library). So it should be feasible to compile just TopologicCore on Linux for example. But we need someone with time and expertise willing to step up and do it.
@topologic said:
The reason I approached this community was to see if there is anyone with the expertise and willingness to look at the C++ TopologicCore and port it to other platforms. Theoretically, Topologic has exactly the same dependency on OCCT (and no other library). So it should be feasible to compile just TopologicCore on Linux for example. But we need someone with time and expertise willing to step up and do it.
OK, had a quick go and I can compile libTopologicCore.so using a cmake build created using cmakeconverter.
I had to add some missing #include statements.
There are lots of VC usages of std::exception() which I replaced with std::runtime_error()
There were a couple of C++ namespace things that I might have fixed correctly (I'm really not a C++ coder)
There were a few lines that I commented out completely, I don't know what this code is trying to do:error: conversion from ‘handle<Geom_BSplineCurve>’ to non-scalar type ‘handle<Geom_Curve>’ requested
It could use some cmake niceties, I hard-coded /usr/include/opencascade for example
It looks that it may be possible to compile some other libraries: TopologicEnergy and TopologicStructure maybe?
I'm guessing compiling is the easy bit, probably this needs a SWIG python library to be useful.
@brunopostle
Thanks for your efforts :D
Being merely a beginner in Python, could only help to test or explore the worflow as an architectural practitioner :p Hope this works out and more peoples can help in various aspects.
@brunopostle said:
OK, had a quick go and I can compile libTopologicCore.so using a cmake build created using cmakeconverter.
I had to add some missing #include statements.
There are lots of VC usages of std::exception() which I replaced with std::runtime_error()
There were a couple of C++ namespace things that I might have fixed correctly (I'm really not a C++ coder)
There were a few lines that I commented out completely, I don't know what this code is trying to do:error: conversion from ‘handle<Geom_BSplineCurve>’ to non-scalar type ‘handle<Geom_Curve>’ requested
It could use some cmake niceties, I hard-coded /usr/include/opencascade for example
It looks that it may be possible to compile some other libraries: TopologicEnergy and TopologicStructure maybe?
I'm guessing compiling is the easy bit, probably this needs a SWIG python library to be useful.
Thanks @brunopostle! I do not recommend dealing with TopologicEnergy and especially not TopologicStructure. I will let the original developer know about these glitches. Perhaps he can find the time to patch them and update the software on github.
@brunopostle fantastic work! Agree that SWIG is needed. After this is solved, there still needs to be builds provided (in particular OSX could be a little tricky as you need Mac hardware) and only then can it be integrated in to UIs like Blender / FreeCAD easily.
@paullee the next step is to create a SWIG wrapper for Topologic, this makes the C++ library available as a normal python library.
This isn't especially difficult, it just requires a bit of understanding of python and C++, but more importantly you need to have some idea of how Topologic wants to be used. Particularly understanding how the existing opencascade python library exposes geometry, so that the new python library is complementary to this.
@topologic do you want me to break those patches up into smaller chunks? They are currently a mixture of lots of obviously correct changes, and a handful of hacks that need a bit of more work by somebody who knows the code.
@topologic do you want me to break those patches up into smaller chunks? They are currently a mixture of lots of obviously correct changes, and a handful of hacks that need a bit of more work by somebody who knows the code.
Yes that would be very helpful. Also if you send me the so file, perhaps I can experiment with it. I already sent your patches to the original developer, but sadly he is not responding.
I imagine a topologic workbench in FreeCAD that would offer the same methods as it does within Dynamo and Grasshopper. We have been able to build interesting spatial analysis workflows with it. As to interfacing with opencascade geometry, it should be very easy as topologic uses the native geometry. Plus we have import/export of brep built in. Thanks again everyone for continuing to push this forward.
@brunopostle said: @topologic do you want me to break those patches up into smaller chunks? They are currently a mixture of lots of obviously correct changes, and a handful of hacks that need a bit of more work by somebody who knows the code.
Yes that would be very helpful. Also if you send me the so file, perhaps I can experiment with it.
@topologic you can apply these patches with patch -p1 < patchfilename
topologic-cmake.patch This just adds six files for a basic cmake build system, it won't affect the existing VC build (this cmake system needs some work, it doesn't have an install target or detection of include paths, but it is good enough to start with).
topologic-include.patch This adds some missing standard C library #include statements, this shouldn't cause any problems either.
topologic-exception.patch This is a big patch, it replaces all the calls to std::exception() with std::runtime_error() because only VC lets you pass a string to std::exception() - you need to check that error messages still do what they are supposed to do on Windows.
topologic-dllexport.patch This just puts dllexport and dllimport inside an #ifdef WIN32 as these mean nothing on Linux - however I'm not 100% sure if WIN32 is defined in VC, so you do need to check this still works on Windows.
topologic-gcc.patch This fixes some namespace issues, though this needs confirmation from a real C++ programmer that I have actually done the right thing.
topologic-misc.patch This comments out two bits of code that I don't understand, which don't compile and which may be bugs, someone who understands this codebase needs to fix this. The error is error: conversion from ‘handle<Geom_BSplineCurve>’ to non-scalar type ‘handle<Geom_Curve>’ requested
(I can send you the .so file though I'm not sure it is suitably portable)
Dear @brunopostle The developer has informed me that he has implemented all the patches and updated the source code on github! Thank you very much for your help with these. If you have any extra time, it would be fantastic if you can confirm that indeed the code now works and can be easily compiled on Linux.
Note that the cmake system still needs a little bit of tweaking so that it works on all platforms, it is also missing an install target, these are probably straightforward fixes.
Note that the cmake system still needs a little bit of tweaking so that it works on all platforms, it is also missing an install target, these are probably straightforward fixes.
Fantastic! many thanks for confirming that it builds. I will let the developer know that it still needs some minor tweaks.
Comments
It seems as though the biggest problem is @topologic 's dependency on .NET. It's theoretically cross-platform, but in practice it's quite Windows-centric and a pain elsewhere.
The reason I approached this community was to see if there is anyone with the expertise and willingness to look at the C++ TopologicCore and port it to other platforms. Theoretically, Topologic has exactly the same dependency on OCCT (and no other library). So it should be feasible to compile just TopologicCore on Linux for example. But we need someone with time and expertise willing to step up and do it.
OK, had a quick go and I can compile libTopologicCore.so using a cmake build created using cmakeconverter.
error: conversion from ‘handle<Geom_BSplineCurve>’ to non-scalar type ‘handle<Geom_Curve>’ requested/usr/include/opencascadefor exampleI'm guessing compiling is the easy bit, probably this needs a SWIG python library to be useful.
I have a ceiling to paint! Here are a couple of patches if anyone else wants to try this, they should apply to the master branch of Topologic
@paullee
@brunopostle
Thanks for your efforts :D
Being merely a beginner in Python, could only help to test or explore the worflow as an architectural practitioner :p Hope this works out and more peoples can help in various aspects.
Thanks @brunopostle! I do not recommend dealing with TopologicEnergy and especially not TopologicStructure. I will let the original developer know about these glitches. Perhaps he can find the time to patch them and update the software on github.
@brunopostle fantastic work! Agree that SWIG is needed. After this is solved, there still needs to be builds provided (in particular OSX could be a little tricky as you need Mac hardware) and only then can it be integrated in to UIs like Blender / FreeCAD easily.
Not sure what to do to bring forward @brunopostle 's works :)
WFIW, there has been a discussion in FreeCAD forum - Anyone interested in bringing Topologic to FreeCAD?
@paullee the next step is to create a SWIG wrapper for Topologic, this makes the C++ library available as a normal python library.
This isn't especially difficult, it just requires a bit of understanding of python and C++, but more importantly you need to have some idea of how Topologic wants to be used. Particularly understanding how the existing opencascade python library exposes geometry, so that the new python library is complementary to this.
Note that freecad seems to have two ways of accessing opencascade.
@topologic do you want me to break those patches up into smaller chunks? They are currently a mixture of lots of obviously correct changes, and a handful of hacks that need a bit of more work by somebody who knows the code.
@paullee it seems that @aothms is working on exactly these issues of inferring spaces and space connectivity from boundaries: https://speakerdeck.com/aothms/validation-and-inference-of-geometrical-relationships-in-ifc
Yes that would be very helpful. Also if you send me the so file, perhaps I can experiment with it. I already sent your patches to the original developer, but sadly he is not responding.
I imagine a topologic workbench in FreeCAD that would offer the same methods as it does within Dynamo and Grasshopper. We have been able to build interesting spatial analysis workflows with it. As to interfacing with opencascade geometry, it should be very easy as topologic uses the native geometry. Plus we have import/export of brep built in. Thanks again everyone for continuing to push this forward.
@topologic you can apply these patches with
patch -p1 < patchfilenametopologic-cmake.patchThis just adds six files for a basic cmake build system, it won't affect the existing VC build (this cmake system needs some work, it doesn't have an install target or detection of include paths, but it is good enough to start with).topologic-include.patchThis adds some missing standard C library#includestatements, this shouldn't cause any problems either.topologic-exception.patchThis is a big patch, it replaces all the calls tostd::exception()withstd::runtime_error()because only VC lets you pass a string tostd::exception()- you need to check that error messages still do what they are supposed to do on Windows.topologic-dllexport.patchThis just putsdllexportanddllimportinside an#ifdef WIN32as these mean nothing on Linux - however I'm not 100% sure ifWIN32is defined in VC, so you do need to check this still works on Windows.topologic-gcc.patchThis fixes some namespace issues, though this needs confirmation from a real C++ programmer that I have actually done the right thing.topologic-misc.patchThis comments out two bits of code that I don't understand, which don't compile and which may be bugs, someone who understands this codebase needs to fix this. The error iserror: conversion from ‘handle<Geom_BSplineCurve>’ to non-scalar type ‘handle<Geom_Curve>’ requested(I can send you the .so file though I'm not sure it is suitably portable)
Sorry I can't make sense of the programming discussion above :oops
It seems it is a lots of works. Hope @nmt in FC may join this effort to make things easier :)
Dear @brunopostle The developer has informed me that he has implemented all the patches and updated the source code on github! Thank you very much for your help with these. If you have any extra time, it would be fantastic if you can confirm that indeed the code now works and can be easily compiled on Linux.
@topologic it now builds ok here:
git clone https://github.com/NonManifoldTopology/Topologic.git
cd Topologic
mkdir BUILD
cd BUILD
cmake ..
make
ldd TopologicCore/libTopologicCore.so
Note that the cmake system still needs a little bit of tweaking so that it works on all platforms, it is also missing an
installtarget, these are probably straightforward fixes.Fantastic! many thanks for confirming that it builds. I will let the developer know that it still needs some minor tweaks.