Bonsai | Revision cloud is disappearing during sheet generation

arunarchitectarunarchitect
in General

Hi all ,
When I try to create a sheet with an already generated drawing(where revsion cloud) is visible, the sheet generated doesnt have it. How can we solve this?


but missing in sheets

Hey @sjb007 , are you out there ;-)

Tagged:

Comments

  • sjb007sjb007

    Here, but I haven't messed with revision clouds. However, if they are in the drawing they should be in the sheet once you re-create the sheet.
    So dumb question: You did click the printer icon in the sheet pane after adding the revision cloud, right?

  • arunarchitectarunarchitect

    @sjb007 said:
    However, if they are in the drawing they should be in the sheet once you re-create the sheet.

    Yeah, I also thought this way, but somehow it's not working.

    You did click the printer icon in the sheet pane after adding the revision cloud, right?

    Yeah, tried a number of times, not working.

  • theoryshawtheoryshaw

    I think it's an open issue...
    https://github.com/IfcOpenShell/IfcOpenShell/issues/4588

    arunarchitect
  • sjb007sjb007

    Yeah, looking at the svg, the rev cloud parts are getting added to the sheet, but when they are merged in as a group (instead of children of the root element) and they are getting modified in a way that is not correct, meaning that it no longer renders the red line correctly. I'll post the explanation/workaround here, and to the ticket.
    When the drawing is added to the sheet the marker elements id changes from revision-cloud-<globalid?> to d######-revision-cloud-<globalid?> (where the 6 hashes are a number). The problem is that the polylines that make up the revcloud borders do not get their style:marker url changed from #revision-cloud-<globalid?> to #d######-revision-cloud-<globalid?>
    A crude workaround is to edit the url to add the d######- part in the sheet, but obviously this is a temporary hack that will be constantly overwritten when the sheet is recreated.

    theoryshawMassimoarunarchitect
  • sjb007sjb007

    Posted a potential fix to the 4588 issue. Needs proper testing on real files.

    theoryshawarunarchitect
  • arunarchitectarunarchitect

    @sjb007 said:
    Posted a potential fix to the 4588 issue. Needs proper testing on real files.

    Great! I wish I could also debug and fix some issues. How can I start? Could you suggest me a roadmap?

  • sjb007sjb007
    edited 1:43PM

    @arunarchitect Do you mean a roadmap for future development of the application, or do you mean a roadmap for your development to be capable of contributing?
    There is https://github.com/IfcOpenShell/IfcOpenShell/projects?query=is:open but I don't think it is particularly used by the main devs. They have their personal "wants" that they work on. [Edit: looks like it was used more heavily in the past] Then there's the big ol' pile of bugs and feature requests at https://github.com/IfcOpenShell/IfcOpenShell/issues
    You find something that bugs you enough to do something about it, just dive in and come up with a fix/solution. If you're undertaking something substantial, maybe discuss at https://app.element.io/?updated=1.11.97#/room/#OSArch:matrix.org first for advice and guidance.
    If you are starting with no coding experience, then that is a lot of work to get to contributing. Minimum needs:

    • Learn Python language
    • Learn Git usage
    • Familiarity with how the Bonsai code is structured
    • Understand a bit about Blenders python API
    • Ideally set up a debugging environment, for which there are guides. This let's you step through code lines, and view variables as the program runs, allowing you to understand what is going on much easier.

    How much of these is necessary depends on what you want to do. A typo needs very little, a big new feature requires a lot.

    theoryshaw
Sign In or Register to comment.