Both displays have their uses, I'm in favor since Bonsai draw the wire as an overlay anyway. However in Edit mode I think the dispaly should be set back to Solid or Texture because the blue wireframe overlay doesn't update in real time in edit mode. Or maybe it should update in real time, in which case the object display could stay in wireframe mode ?
Might have been nice to see some actual editing of the void. It's definitely not ideal at the before your change, but your clip didn't give me a sense of what the editing user experience is after your change. I'll monkey-patch it in here and have a look.
If I had one criticism, it's when I select an edge that is aligned with one of the blue wireframe edges I can't see the selection, although I think that is not related to your patch.
Comments
Not from me. I typically end up in X-Ray mode trying to tweak things.
Both displays have their uses, I'm in favor since Bonsai draw the wire as an overlay anyway. However in Edit mode I think the dispaly should be set back to Solid or Texture because the blue wireframe overlay doesn't update in real time in edit mode. Or maybe it should update in real time, in which case the object display could stay in wireframe mode ?
Added here: https://github.com/IfcOpenShell/IfcOpenShell/commit/586f9be0778f589540b5ba103c01397c52c850fa
Also, added some functionality where you can keep hitting tab to cycle in and out of edit mode.
Might have been nice to see some actual editing of the void. It's definitely not ideal at the before your change, but your clip didn't give me a sense of what the editing user experience is after your change. I'll monkey-patch it in here and have a look.
Thumbs up from me! Nice!
If I had one criticism, it's when I select an edge that is aligned with one of the blue wireframe edges I can't see the selection, although I think that is not related to your patch.
@theoryshaw nice one ! Maybe now we can get rid of the ESCAPE modal operator that prevents autosave :) https://github.com/IfcOpenShell/IfcOpenShell/issues/5849
Works for me.
Unfortunately not much time on my end to once again update my dev setup for the new releases so I'm stuck with what y'all are able to do :-'(