@bernd I haven't worked with gettext personally so I don't know how the system works (I assume mo is generated from po?). I trust you to make the right decision. Feel free to just go for it - I'll merge any PR you make as soon as I can :) I haven't looked much at the bimtester code for a while, so when I get the time to hack on it again maybe I'll have more opinions.
I'll create an issue asking Thomas to give you commit access so you don't need to keep on submitting PRs. In general so long as you stick to the Python code and ask before editing other codebases before you are familiar, just go for it :) In the case of BIMTester, I think you are more than familiar and I'm happy for you to hack on it any way you see fit! Especially as you are also testing it in real life which is the most important!
OK, great.
In the regard of write access. As maintainer of FreeCAD FEM I have write access to FreeCAD main repo. But I only write to FEM, Arch and Draft. For all other changes I go for a PR. Means I am used to such work flow.
Very nice @bernd . I'd like to offer my help with translation to Italian and Dutch @Meetlat. Do I need any special write permissions, do I need to create a fork or can I just start by copying in same location and renaming an existing file in another language, like e.g "geometric_detail_de.py" to "geometric_detail_it.py"?
@tlang said:
Very nice @bernd . I'd like to offer my help with translation to Italian and Dutch @Meetlat. Do I need any special write permissions, do I need to create a fork or can I just start by copying in same location and renaming an existing file in another language, like e.g "geometric_detail_de.py" to "geometric_detail_it.py"?
depends if you would like to use BIMTester yourself or just like to help with translation. If you would like to run it yourself you should get to work it before start with translation. It needs some dependencies. If you just would like to help with translation, I would set up everything to be ready to just translate into Italian and Dutch. You would not need to run bimtester yourself.
See attachment. When the translation is integrated I will check the texts. Now I miss the context of the sentences.
Also I noticed that some mistakes? For example see line 63 of messages.po (msgid "" "For all {elemcount} {ifc_class} elements at least one of these class "
"attributes {parameter} has no value.") I thing this should be (msgid "For all {elemcount} {ifc_class} elements at least one of these class "
"attributes {parameter} has no value.") So no empty (msgid "") right? I corrected those
@bernd I'm attaching the three files I understood needed to be translated. As @Meetlat I'd like to use the programme to understand if the translation is good in it's context. As to correctness of the source, I don't understand about the double occurrences of {elemcount} {elemcount} in messages.po.
@given("Het IFC-bestand is aangeleverd via een argument")
or perhaps this is better: @given("Het IFC-bestand is aangeleverd via een parameter")
The term parameter is more common than argument
@bernd I installed the latest blenderbim addin. When selecting bimtester it asks me for the feature file directory. Now how do I load all the feature files from the github repository?
@tlang - I've significantly changed the BIMTester behaviour now to request a single feature file by default. The ability to do a bulk feature check will turn into an advanced user option. Maybe it's best to wait until the next version. Perhaps @condur and I can do a video explaining it too.
@Moult my question meant to be more on how to actually download the feature files to my hard drive. I would like to run some single feature files, also to check my translation to Italian. Having said that I would much appreciate a video explainer.
Regarding use cases I found back an article that implements Dutch and Norwegian national BIM requirements. Maybe Bimtester could do the same?
install dependencies: behave (at least 1.2.6) and pystache, ahh and for sure Python3 and PySide2
switch into directory src/ifcbimtester and start bimtester gui by the use of parameter -g but this seams to has changed
in the gui one just need to set a directory. all feature files in the directory are used by the BIMTester run and a report is created for each feature file
neither BlenderBIM nor FreeCAD are really needed to run BIMTester
but as said this was befor dijon has changed some stuff ...
Fonctionnalité: Base setup ( Configuration primaire )
In order to view the BIM data ( pour permettre la visualisation des données BIM )
As any interested stakeholder ( ainsi que quelque Participant intéressé ) or ( comme tout participant intéressé )
We need an IFC file ( ceci requiert un fichier IFC )
Scénario: Recevoir e fichier
Les données IFC doivent utiliser le schéma "IFC2X3"
Scénario: Project information ( Informations concernant le projet )
The project name, code, or short identifier must be "BIMTester Example 1 - IFC2X3" ( Nom du projet, son code ou un identifiant sommaire du type "BIMTester1-IFC2x3" )
Comments
how about this ... https://gitlab.com/bimtester/bimtesterfc/-/commits/main
@bernd I don't see an issue with showing an error for untranslated strings - it's a prompt for translators to resolve it :)
@Moult https://github.com/IfcOpenShell/IfcOpenShell/pull/1181
Just realized, I commited mo files. But the should not be in the git of ifcopenshell or should they?
@bernd I haven't worked with gettext personally so I don't know how the system works (I assume mo is generated from po?). I trust you to make the right decision. Feel free to just go for it - I'll merge any PR you make as soon as I can :) I haven't looked much at the bimtester code for a while, so when I get the time to hack on it again maybe I'll have more opinions.
I'll create an issue asking Thomas to give you commit access so you don't need to keep on submitting PRs. In general so long as you stick to the Python code and ask before editing other codebases before you are familiar, just go for it :) In the case of BIMTester, I think you are more than familiar and I'm happy for you to hack on it any way you see fit! Especially as you are also testing it in real life which is the most important!
OK, great.
In the regard of write access. As maintainer of FreeCAD FEM I have write access to FreeCAD main repo. But I only write to FEM, Arch and Draft. For all other changes I go for a PR. Means I am used to such work flow.
Most of translation framework has settled down. If someone is interested in translating some of bimtester strings, templates and step tests, go ahead ... https://github.com/IfcOpenShell/IfcOpenShell/tree/v0.6.0/src/ifcbimtester
How to get started
Very nice @bernd . I'd like to offer my help with translation to Italian and Dutch @Meetlat. Do I need any special write permissions, do I need to create a fork or can I just start by copying in same location and renaming an existing file in another language, like e.g "geometric_detail_de.py" to "geometric_detail_it.py"?
That would be great.
depends if you would like to use BIMTester yourself or just like to help with translation. If you would like to run it yourself you should get to work it before start with translation. It needs some dependencies. If you just would like to help with translation, I would set up everything to be ready to just translate into Italian and Dutch. You would not need to run bimtester yourself.
find two branches:
Best to start with the feature file an the one string in the python file. Afterwards translating the po file makes sense. Work as you like either make it on github or post the translated file here.
cheers bernd
rebase start dutch and italian translation. Would be cool if someone could translate the feature file. See https://github.com/berndhahnebach/IfcOpenShell/blob/07e2dc29b655f43d8515110263396ab86ef58914/src/ifcbimtester/examples/01_ifcschema_translated/features/grondslag.feature and https://github.com/berndhahnebach/IfcOpenShell/blob/e20bf5ffe98bb83c80247c6cf922617842231e5d/src/ifcbimtester/examples/01_ifcschema_translated/features/fondamento.feature
See attachment. When the translation is integrated I will check the texts. Now I miss the context of the sentences.
Also I noticed that some mistakes? For example see line 63 of messages.po (msgid "" "For all {elemcount} {ifc_class} elements at least one of these class "
"attributes {parameter} has no value.") I thing this should be (msgid "For all {elemcount} {ifc_class} elements at least one of these class "
"attributes {parameter} has no value.") So no empty (msgid "") right? I corrected those
@bernd I'm attaching the three files I understood needed to be translated. As @Meetlat I'd like to use the programme to understand if the translation is good in it's context. As to correctness of the source, I don't understand about the double occurrences of {elemcount} {elemcount} in messages.po.
great stuff ...
https://github.com/IfcOpenShell/IfcOpenShell/commit/9574b7e08f2 and https://github.com/IfcOpenShell/IfcOpenShell/commit/9574b7e08f2 Would be great if you could give it a try in real. An example is included. See https://github.com/IfcOpenShell/IfcOpenShell/tree/b9ba138d8d9/src/ifcbimtester/examples/01_ifcschema_translated
teh dutch still misses an important translation. https://github.com/IfcOpenShell/IfcOpenShell/blob/45bba127ff56940c8864de98eb009ff7abe5d086/src/ifcbimtester/bimtester/features/steps/ifcdata_nl.py#L12
@given("Het IFC-bestand is aangeleverd via een argument")or perhaps this is better:
@given("Het IFC-bestand is aangeleverd via een parameter")The term parameter is more common than argument
@bernd I installed the latest blenderbim addin. When selecting bimtester it asks me for the feature file directory. Now how do I load all the feature files from the github repository?
@tlang - I've significantly changed the BIMTester behaviour now to request a single feature file by default. The ability to do a bulk feature check will turn into an advanced user option. Maybe it's best to wait until the next version. Perhaps @condur and I can do a video explaining it too.
@Moult my question meant to be more on how to actually download the feature files to my hard drive. I would like to run some single feature files, also to check my translation to Italian. Having said that I would much appreciate a video explainer.
Regarding use cases I found back an article that implements Dutch and Norwegian national BIM requirements. Maybe Bimtester could do the same?
Dion has done some changes lately I have not yet tested. But before it was very easy if you are on a linux machine ...
but as said this was befor dijon has changed some stuff ...
ahh here we are ... more information about the changes ... https://community.osarch.org/discussion/comment/5449/#Comment_5449
@Bernd.. Dijon a sa moutarde; l'Australie et nous avons Dion. :-)
@tlang feature files are plain text. You type whatever you want into notepad and save it with a file extension of .feature.
The readme might help: https://github.com/IfcOpenShell/IfcOpenShell/tree/v0.6.0/src/ifcbimtester
@bernd sorry but, so far I'm on windows10, with Github Desktop i try to clone the repository: https://github.com/IfcOpenShell/IfcOpenShell/tree/5f8e77c29281ffd778ee530051fbe45b68eae19d/src/ifcbimtester
but I get an authentication failure. I've assumed it's a Github Desktop bug I've reported: https://github.com/desktop/desktop/issues/11536
Could it instead be an access limitation on your side?
@tlang the clone url should be: https://github.com/IfcOpenShell/IfcOpenShell.git
That fixed it thank you @Moult !
Very effective work, I plan to translate it into Chinese in the next few months. Maybe I will need your help then.
Fantastic!
Some French speaker is needed ...
https://github.com/IfcOpenShell/IfcOpenShell/tree/v0.7.0/src/ifcbimtester/examples/01_ifcschema_translated/features
In the french feature file a translation is missing. See https://github.com/IfcOpenShell/IfcOpenShell/blob/6853735bb26d476e40892a9ec0e0f8ad3b52645a/src/ifcbimtester/examples/01_ifcschema_translated/features/fr_fondamentaux.feature#L17
language: fr
Fonctionnalité: Base setup ( Configuration primaire )
In order to view the BIM data ( pour permettre la visualisation des données BIM )
As any interested stakeholder ( ainsi que quelque Participant intéressé ) or ( comme tout participant intéressé )
We need an IFC file ( ceci requiert un fichier IFC )
Scénario: Recevoir e fichier
Scénario: Project information ( Informations concernant le projet )